TST: Replace ensure_clean_store with temp_file in test_time_series.py #62652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace ensure_clean_store utility function with the temp_file pytest fixture in pandas/tests/io/pytables/test_time_series.py. Changes: - Remove import of ensure_clean_store from pandas.tests.io.pytables.common - Add HDFStore to pandas imports - Replace setup_path parameter with temp_file in all test functions - Replace context manager usage of ensure_clean_store(setup_path) with HDFStore(temp_file) Contributes to issue pandas-dev#62435
|
“If the test failure is unrelated to my refactor, please let me know if further changes are needed. Happy to make updates if necessary!” |
swt2c
reviewed
Oct 11, 2025
VYaswanthKumar
commented
Oct 11, 2025
|
Restored the import datetime line as requested. All feedback addressed and waiting for CI checks |
|
Looks like now you've made a bunch of whitespace changes in |
Restore original formatting with proper blank lines between methods and sections to keep the PR clean and focused on the actual test changes.
VYaswanthKumar
commented
Oct 13, 2025
mroeschke
approved these changes
Oct 13, 2025
|
Thanks @VYaswanthKumar |
mraabhijit
pushed a commit
to mraabhijit/pandas
that referenced
this pull request
Oct 17, 2025
…pandas-dev#62652) Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
eicchen
pushed a commit
to eicchen/pandas
that referenced
this pull request
Oct 18, 2025
…pandas-dev#62652) Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace ensure_clean_store utility function with the temp_file pytest fixture in pandas/tests/io/pytables/test_time_series.py.
Changes:
Contributes to issue #62435
ensure_cleanutility function with thetemp_filepytest fixture #62435 (contributes to this issue)doc/source/whatsnew/vX.X.X.rstfile (not applicable - test refactoring only)